[All] Add http_request_kwargs config option
#578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
approved these changes
Mar 13, 2023
|
I was hoping to test this in a real environment with a proxy but haven't had time. However I have tested it with a pretend proxy (basically setting up a http listener, tell oauthneticator to use that as a proxy and verifying that a connection request is sent. It doesn't actually work beyond that since it's not a real proxy so the auth fails, but it shows the proxy is being used). |
consideRatio
approved these changes
Apr 4, 2023
consideRatio
changed the title
http_request_kwargs config option
|
Nice!!! Super happy to see how this managed addressed multiple authenticators issues in one go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new config property
http_request_kwargsthat allows additional keyword args to be passed by default totornado.HTTPRequest.This can for example be used to pass HTTP proxy configuration.
Closes #217
Closes #403